Bug List

Class _MetaDrawOpList

Do we really win anything from not using the equivalent GLib structures?

Class _MetaFrameLayout

button_sizing isn't really necessary, because we could easily say that if button_aspect is zero, the height and width are fixed values. This would also mean that MetaButtonSizing didn't need to exist, and save code.

Global _MetaFrameLayout::title_border

(blue?!)

Class _MetaTheme

It is rather useless to keep the metadata fields in core, I think.

Global _MetaTheme::filename

Kept lying around for no discernable reason.

Class PosExpr

operator is char; it should really be of PosOperatorType.

Global bell_flash_screen

The way I read it, this appears not to do the flash the first time we flash a particular display. Am I wrong?

Global bell_flash_screen

This appears to destroy our current XSync status.

Global bell_unflash_frame

This is the parallel to bell_flash_window_frame(), so it should really be called meta_bell_unflash_window_frame().

Global bell_visual_notify

This should be merged with meta_bell_notify().

Global meta_bell_init

There is a line of code that's never run that tells XKB to reset the bell status after we quit. Bill H said (<http://bugzilla.gnome.org/show_bug.cgi?id=99886#c12>) that XFree86's implementation is broken so we shouldn't call it, but that was in 2002. Is it working now?

Global meta_bell_shutdown

This is never called! If we had XkbSetAutoResetControls enabled in meta_bell_init(), this wouldn't be a problem, but we don't.

Global meta_is_syncing

This is *only* called by meta_display_open, but by that time we have already turned syncing on or off on startup, and we don't have any way to do so while Metacity is running, so it's rather pointless.

Global meta_set_syncing

Of course there is only one display ever anyway, so this can be rather hugely simplified.

Global main

It's a bit long. It would be good to split it out into separate functions.

Global prefs_changed_callback

Why are these particular prefs handled in main.c and not others? Should they be?

Global meta_stack_get_default_focus_window

Never called!

Global meta_stack_update_layer

What's with the dummy parameter?

Global meta_stack_update_transient

What's with the dummy parameter?

File window-props.c

Not all the properties have moved over from their original handler in window.c yet.

File theme.c

This is a big file with lots of different subsystems, which might be better split out into separate files.

Global MetaButtonSizing

This could be done away with; see the comment at the top of MetaFrameLayout.

Global meta_display_ping_window

This should probably be a method on windows, rather than displays for one of their windows.

Global meta_display_window_has_pending_pings

This should probably be a method on windows, rather than displays for one of their windows.

Group tokenizer

We could remove almost all this code by using GScanner instead, but we would also have to find every expression in every existing theme we could and make sure the parse trees were the same.

Global parse_number

The "while (*start)..." part: what's wrong with strchr-ish things?

Global parse_number

The name is wrong: it doesn't parse anything.

Global pos_eval

Shouldn't spec be const?

Global pos_eval_get_variable

shouldn't t be const?

Global pos_eval_get_variable

we should perhaps consider some sort of lookup arrangement into an array; also, the duplication of code is unlovely; perhaps using glib string hashes instead of quarks would fix both problems?

Global pos_eval_helper

Yes, we really do reparse the expression every time it's evaluated. We should keep the parse tree around all the time and just run the new values through it.